feat: Improve useChainState and standardize contract loading
#50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bowd
commented
Jan 31, 2024
bayological
changed the title
useChainState and standardize contract loadinguseChainState and standardize contract loading
|
@bowd made some slight changes to incorporate all contract addresses. |
bayological
requested review from
a team,
chapati23,
baroooo and
denviljclarke
and removed request for
a team and
chapati23
denviljclarke
approved these changes
Feb 1, 2024
baroooo
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It improves the chain state helper definition and loading and exposes a
useContractshook used throughout the app.The problem with this PR right now is that the addresses in the SDK are not the ones that are indexed in
The Graphthat is a separate deployment. I will migrate the indexers to this deployment as well.After I do that, however, we will have no test proposals because the ones that I created are on the other deployment.
We need a small script to seed the deployment with some test proposals that have votes.
Other changes
Tested
Related issues